-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial for multiple robot arms with MoveIt #708
Conversation
Thanks for helping in improving MoveIt and open source robotics! |
@AndyZe, can you have a look? |
catkin create pkg panda_multiple_arms | ||
cd panda_multiple_arms | ||
mkdir robot_description | ||
touch panda_multiple_arms.xacro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the robot_description
directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not have to, but I think this makes logical structure. Should I change it?
Truly thankful for the review, @jackcenter I followed the tutorial from a beginner's perspective, revised every step, and fixed multiple issues. Luckily, the fix I made in the Hopefully, this tutorial will greatly help the community, including the users of the new simultaneous trajectory execution feature! Once it's done, I will port it to ROS 2. Please review the tutorial one more time and let me know your suggestions, or if it's ready to be merged. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your patience and diligence in pushing this forward!
I'm sorry to say, when I run build_locally.sh
, I don't see your new tutorial in the webpage. I'm not sure why, yet.
Please disregard, that was an error on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a very high-quality tutorial that explains a lot of concepts well!
It looks like the formatting of multiple_robot_arms.rst
needs a bit of tweaking because too many bullet points show up when the webpage is built. You can build the webpage to test this with build_locally.sh
if you did not know that already (in the root directory of this repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you could delete CMakeLists.txt
and package.xml
from this PR since you instruct the user to catkin create pkg
Almost there! I think we can get this merged in the next few days. |
Co-authored-by: AndyZe <[email protected]>
The formatting is fixed, and it looks good on the locally built webpage. Thank you for pointing out this issue! I removed the word I think the tutorial is ready for the final review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This meets my quality standards now 👍 Thanks for going into such detail. I think this will help people put many concepts together.
I'll merge if we can just get CI passing now.
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
Truly thankful for your time and comments, @AndyZe I planned this tutorial to be the start of my contributions to MoveIt, and glad this step is done. |
Description
The goal of this tutorial is to be a complete guide for ROS beginners to start by setting up the URDF model of the multiple arms to be able to plan motions for them. The steps are as follows.
Progress
I followed the moveit_tutorials guideline and applied the flow of
show to tell
style. I used the Panda arm from FRANKA EMIKA for consistency with previous tutorials. I have already completed the first three steps of the tutorial. The fourth step is blocked by the provided official Panda hand model missing inertial elements, making it unready for Gazebo simulation. I could proceed with fixing the links missing the inertial elements, but this means another package than franka_description would be a dependency for the tutorial. **I wanted to ask my mentors, should it be done in this way? **I am flexible in refining the content according to the need and preventing redundancy.
Checklist