Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMD Track: Tutorial cleanup #1293

Closed
AndyZe opened this issue May 31, 2022 · 11 comments
Closed

WMD Track: Tutorial cleanup #1293

AndyZe opened this issue May 31, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@AndyZe
Copy link
Member

AndyZe commented May 31, 2022

This track will be about tutorial cleanup (https://github.com/ros-planning/moveit2_tutorials).

I'll help people select and scope their work, and guide them to get contributions finished and merged.

There are tons of things to clean up. Here are a few that come to mind:

Anybody (@tylerjw) please feel free to add more ideas.

@AndyZe AndyZe added the enhancement New feature or request label May 31, 2022
@AndrejOrsula
Copy link

Hello!

If it is alright and available, I would take a look at moveit_calibration.
Primary objectives:

  1. See what is missing from moveit_calibration#101 ([WIP] ROS2 Port) and attempt to finalise it. Last messages under the related issue#99 claim that it is not currently functional.
  2. [If deemed relevant] Setup simulation environments in Ignition Gazebo (target fortress) to provide a simplified method of testing/demonstrating/developing both eye-in-hand and eye-to-hand scenarios, without having to hassle with real robot setups. I am not sure if something like that already exists, so please correct me if I am wrong.
  3. Update Hand-Eye Calibration tutorial for ROS 2

Please, let me know what you think. Thank you.

PS: I am not sure what WMD Track this would belong to, but this issue seemed like the best place for it. 😄


Also, if you think there is anything relevant for tutorials / MSA in any of these repositories (and not already present/planned in moveit2 repos), then I would be happy to work on that as well.

@vatanaksoytezer
Copy link
Contributor

Hey @AndrejOrsula thanks for all the work so far!

Also, if you think there is anything relevant for tutorials / MSA in any of these repositories (and not already present/planned in moveit2 repos), then I would be happy to work on that as well.

Although I think calibration would be a higher priority, eventually, a tutorial that demonstrates how to use Ignition Gazebo with MoveIt 2 and ros2_control would be very valuable.

@AndyZe
Copy link
Member Author

AndyZe commented Jun 1, 2022

Small warning: the author of moveit_calibration has moved on, so we aren't really familiar with that codebase and might not be able to offer as much support as we could in other areas. But if you feel confident to debug moveit_calibration yourself, we will definitely support testing and merging.

@AndyZe
Copy link
Member Author

AndyZe commented Jun 1, 2022

Is anybody interested in taking on a dual-arm tutorial? I can give guidance and I have example code to refer to. That seems like a high priority

@pabloinigoblasco
Copy link
Contributor

pabloinigoblasco commented Jun 1, 2022

We tried to make work any demo of ros2_control, moveit and multiple arms a few times in these last months. We didnt success and I think that is not currently possible. I will try to explain our conclusions:

  • There are like a few possible strategies:
    • using namespaces for ros2_control/move_group/move_group_interface client
    • putting everything in the same root namespace using topic/action remapping
    • using one single robot with a description with two arms and one single moveit_interface_client for the whole robot

General conclusions:

  • ros2_control likes topic/action remapping for multiple arms (over controllers in separated namespaces)
  • moveit likes namespaces for multiple arms (over multiple nodes in the same level and remapping)

Specific details:

  • It is not possible to work with a mixture solution. if movegroup works in a namespace it looks like it cant connect with controllers in the root level (this would have been a solution). I would say the names of the controllers are relative to the move_group namespace.

  • moveit does not work well with topic/actions remapping in the same root namespace, there are collisions on topics and actions you cant remap. We found this is specially clear when you work with multiple moveit_client_interfaces. We didnt find a way of avoid this collisions only with remapping (and without using namespaces)

The only potential solution we did not test is something like having one single robot description with two arms. In our case we wanted to use ur5, and that would have been implied to do a lot of work on ur5_description to work well in the same robot. This same solution would imply to use one single move_group_interface client with multiple groups.

That's it.

@AndyZe @bmagyar may this be a more detailed description that could help on finding a solution?

@davetcoleman
Copy link
Member

I'll be working through and cleaning up tutorials now!

@AndyZe
Copy link
Member Author

AndyZe commented Jun 2, 2022

I'm planning to consolidate the two MTC tutorials now unless somebody is already doing that.

@AndyZe
Copy link
Member Author

AndyZe commented Jun 2, 2022

^scratch that, i'll work on landing the integration test PR instead: moveit/moveit2_tutorials#389

@tiffanyec
Copy link

I'll consolidate the task constructor tutorials. The one we want to keep is this one right? https://moveit.picknik.ai/main/doc/tutorials/pick_and_place_with_moveit_task_constructor/pick_and_place_with_moveit_task_constructor.html

@AndyZe
Copy link
Member Author

AndyZe commented Jun 2, 2022

Correct! Thank you 👍

@AndyZe
Copy link
Member Author

AndyZe commented Jun 6, 2022

Closing because World MoveIt Day is over. Thanks everybody.

@AndyZe AndyZe closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants