issue#45: trigger course_module_updated on dates update#50
issue#45: trigger course_module_updated on dates update#50dmitriim wants to merge 1 commit intomoodleou:mainfrom
Conversation
| * @param \block_base $block the block to save the dates for. | ||
| * @param array $dates a list of new dates. | ||
| */ | ||
| final public function save_new_dates(block_base $block, array $dates) { |
There was a problem hiding this comment.
There is no real reason to do have this new method for for the block instance. It's done for consistency.
There was a problem hiding this comment.
I'm not too sure what you mean by consistence here. Consistency with what?
There was a problem hiding this comment.
So we added save_new_dates method to modules related class, hence I'd like to keep it consistent for blocks as well. But technically there is no reason to do so as we don't trigger anything for the blocks.
There was a problem hiding this comment.
If even Cameron does not understand what is giong on here, then you need to improve the comment (instead of answering in github comment which will neve be seen again.)
You also need to write your pull request to explain what you are doing and why. Yiou may konw, but I am not telepathic.
There was a problem hiding this comment.
I have updated a pull request description to explain what's happening in the code. As well as added comment to explain a new method a little bit more. Please have a look and let me know if that's better now.
|
Thanks @dmitriim - the code here seems reasonable to me. Just one small comment to address but it's minor - and actually after looking a bit longer I'm pretty sure I understand what was meant by consistency. |
3 participants
This pull request adds triggering \core\event\course_module_updated event after updating a date for a specific activity.
This is required as technically activity is getting updated when dates get changed.