prevent the creation of embedded models #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
embedded-model
branch
2 times, most recently
from
8df7cfe to
87be36a
Compare
timgraham
force-pushed
the
embedded-model
branch
2 times, most recently
from
8884610 to
05a3ee1
Compare
Jibola
reviewed
Jan 21, 2025
Comment on lines
+651
to
+667
| def test_embedded_add_field_ignored(self): | ||
| """add_field() and remove_field() ignore EmbeddedModel.""" | ||
| new_field = models.CharField(max_length=1, default="a") | ||
| new_field.set_attributes_from_name("char") | ||
| with connection.schema_editor() as editor, self.assertNumQueries(0): | ||
| editor.add_field(Author, new_field) | ||
| with connection.schema_editor() as editor, self.assertNumQueries(0): | ||
| editor.remove_field(Author, new_field) | ||
|
|
||
| def test_embedded_alter_field_ignored(self): | ||
| """alter_field() ignores EmbeddedModel.""" | ||
| old_field = models.CharField(max_length=1) | ||
| old_field.set_attributes_from_name("old") | ||
| new_field = models.CharField(max_length=1) | ||
| new_field.set_attributes_from_name("new") | ||
| with connection.schema_editor() as editor, self.assertNumQueries(0): | ||
| editor.alter_field(Author, old_field, new_field) |
There was a problem hiding this comment.
A little confused here. Why would we want them ignored?
There was a problem hiding this comment.
While we still don't detect changes to embedded models as part of the parent model, makemigrations still generates a migration as if the EmbeddedModel has its own collection and we need to ignore that rather than trying to run some change on a nonexistent collection.
Jibola
approved these changes
Jan 22, 2025
timgraham
force-pushed
the
embedded-model
branch
from
05a3ee1 to
19ef748
Compare
5 tasks
|
@timgraham Just noticed after merging this PR Is it OK to add a |
|
This may be a difficult one: #243. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #216