Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-43200: Get started #10

Merged
merged 13 commits into from
Jan 27, 2025
Merged

DOCSP-43200: Get started #10

merged 13 commits into from
Jan 27, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jan 21, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43200
Old PR (got approval x4): mongodb/docs-pymongo#132

Staging Links

  • get-started
  • get-started/connect-mongodb
  • get-started/connection-string
  • get-started/create-admin
  • get-started/create-app
  • get-started/create-deployment
  • get-started/install
  • get-started/next-steps
  • get-started/query-data
  • get-started/write-data
  • index

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Jan 21, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-django ready!

    Name Link
    🔨 Latest commit 1c91a13
    🔍 Latest deploy log https://app.netlify.com/sites/docs-django/deploys/6793be2e7633e70008e2ae0e
    😎 Deploy Preview https://deploy-preview-10--docs-django.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @norareidy norareidy mentioned this pull request Jan 21, 2025
    Closed
    5 tasks
    @norareidy norareidy requested a review from R-shubham January 21, 2025 23:50
    timgraham
    timgraham reviewed Jan 22, 2025
    View reviewed changes
    source/includes/get-started/models.py Outdated
    from django.conf import settings
    from django_mongodb_backend.fields import EmbeddedModelField, ArrayField

    class Award(models.Model):
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Embedded models (Award) should now inherit django_mongodb_backend.models.EmbeddedModel rather than models.Model (see mongodb/django-mongodb-backend#227).

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Fixed! I'll update the other PRs as well

    @norareidy norareidy merged commit 8be45de into mongodb:master Jan 27, 2025
    5 checks passed
    @norareidy norareidy deleted the DOCSP-43200-django-get-started branch January 27, 2025 15:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @timgraham timgraham timgraham left review comments

    @Jibola Jibola Jibola approved these changes

    @R-shubham R-shubham Awaiting requested review from R-shubham

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @norareidy @timgraham @Jibola