-
Notifications
You must be signed in to change notification settings - Fork 229
fix(compass-crud): show "expand all / collapse all" button on readonly documents COMPASS-4635 #6265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ import type Document from 'hadron-document'; | |
import type { TypeCastMap } from 'hadron-type-checker'; | ||
import { withPreferences } from 'compass-preferences-model/provider'; | ||
import { getInsightsForDocument } from '../utils'; | ||
import { DocumentEvents } from 'hadron-document'; | ||
type BSONObject = TypeCastMap['Object']; | ||
|
||
export const documentStyles = css({ | ||
|
@@ -30,10 +31,73 @@ export type ReadonlyDocumentProps = { | |
showInsights?: boolean; | ||
}; | ||
|
||
type ReadonlyDocumentState = { | ||
expanded: boolean; | ||
}; | ||
|
||
/** | ||
* Component for a single readonly document in a list of documents. | ||
*/ | ||
class ReadonlyDocument extends React.Component<ReadonlyDocumentProps> { | ||
class ReadonlyDocument extends React.Component< | ||
ReadonlyDocumentProps, | ||
ReadonlyDocumentState | ||
> { | ||
constructor(props: ReadonlyDocumentProps) { | ||
super(props); | ||
this.state = { | ||
expanded: props.doc.expanded, | ||
}; | ||
} | ||
|
||
/** | ||
* Subscribe to the update store on mount. | ||
*/ | ||
componentDidMount() { | ||
this.subscribeToDocumentEvents(this.props.doc); | ||
} | ||
|
||
/** | ||
* Refreshing the list updates the doc in the props so we should update the | ||
* document on the instance. | ||
*/ | ||
componentDidUpdate(prevProps: ReadonlyDocumentProps) { | ||
if (prevProps.doc !== this.props.doc) { | ||
this.unsubscribeFromDocumentEvents(prevProps.doc); | ||
this.subscribeToDocumentEvents(this.props.doc); | ||
} | ||
} | ||
|
||
/** | ||
* Unsubscribe from the update store on unmount. | ||
*/ | ||
componentWillUnmount() { | ||
this.unsubscribeFromDocumentEvents(this.props.doc); | ||
} | ||
|
||
/** | ||
* Subscribe to the document events. | ||
*/ | ||
subscribeToDocumentEvents(doc: Document) { | ||
doc.on(DocumentEvents.Expanded, this.handleExpanded); | ||
doc.on(DocumentEvents.Collapsed, this.handleCollapsed); | ||
} | ||
|
||
/** | ||
* Unsubscribe from the document events. | ||
*/ | ||
unsubscribeFromDocumentEvents(doc: Document) { | ||
doc.on(DocumentEvents.Expanded, this.handleExpanded); | ||
doc.on(DocumentEvents.Collapsed, this.handleCollapsed); | ||
} | ||
|
||
handleExpanded = () => { | ||
this.setState({ expanded: true }); | ||
}; | ||
|
||
handleCollapsed = () => { | ||
this.setState({ expanded: false }); | ||
}; | ||
|
||
handleClone = () => { | ||
const clonedDoc = this.props.doc.generateObject({ | ||
excludeInternalFields: true, | ||
|
@@ -48,6 +112,19 @@ class ReadonlyDocument extends React.Component<ReadonlyDocumentProps> { | |
this.props.copyToClipboard?.(this.props.doc); | ||
}; | ||
|
||
/** | ||
* Handle clicking the expand all button. | ||
*/ | ||
handleExpandAll = () => { | ||
const { doc } = this.props; | ||
// Update the doc directly - the components internal state will update via events | ||
if (doc.expanded) { | ||
doc.collapse(); | ||
} else { | ||
doc.expand(); | ||
} | ||
}; | ||
|
||
/** | ||
* Get the elements for the document. | ||
* | ||
|
@@ -64,6 +141,8 @@ class ReadonlyDocument extends React.Component<ReadonlyDocumentProps> { | |
onClone={ | ||
this.props.openInsertDocumentDialog ? this.handleClone : undefined | ||
} | ||
onExpand={this.handleExpandAll} | ||
expanded={this.state.expanded} | ||
insights={ | ||
this.props.showInsights | ||
? getInsightsForDocument(this.props.doc) | ||
|
@@ -94,7 +173,6 @@ class ReadonlyDocument extends React.Component<ReadonlyDocumentProps> { | |
static propTypes = { | ||
copyToClipboard: PropTypes.func, | ||
doc: PropTypes.object.isRequired, | ||
expandAll: PropTypes.bool, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was extraenuous. Most likely a leftover from some prop that got removed. |
||
openInsertDocumentDialog: PropTypes.func, | ||
showInsights: PropTypes.bool, | ||
}; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly copied from the
EditableDocument
to react to relevant events on thedoc
.