fix(compass-crud): show "expand all / collapse all" button on readonly documents COMPASS-4635#6265
Closed
kraenhansen wants to merge 3 commits intomainfrom
Closed
fix(compass-crud): show "expand all / collapse all" button on readonly documents COMPASS-4635#6265kraenhansen wants to merge 3 commits intomainfrom
kraenhansen wants to merge 3 commits intomainfrom
Conversation
kraenhansen
changed the title
kraenhansen
commented
Sep 19, 2024
| }); | ||
|
|
||
| const expandButton = css({ | ||
| '& > div:has(svg)': { |
Contributor
Author
kraenhansen
commented
Sep 19, 2024
Comment on lines
+52
to
+99
| /** | ||
| * Subscribe to the update store on mount. | ||
| */ | ||
| componentDidMount() { | ||
| this.subscribeToDocumentEvents(this.props.doc); | ||
| } | ||
|
|
||
| /** | ||
| * Refreshing the list updates the doc in the props so we should update the | ||
| * document on the instance. | ||
| */ | ||
| componentDidUpdate(prevProps: ReadonlyDocumentProps) { | ||
| if (prevProps.doc !== this.props.doc) { | ||
| this.unsubscribeFromDocumentEvents(prevProps.doc); | ||
| this.subscribeToDocumentEvents(this.props.doc); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Unsubscribe from the update store on unmount. | ||
| */ | ||
| componentWillUnmount() { | ||
| this.unsubscribeFromDocumentEvents(this.props.doc); | ||
| } | ||
|
|
||
| /** | ||
| * Subscribe to the document events. | ||
| */ | ||
| subscribeToDocumentEvents(doc: Document) { | ||
| doc.on(DocumentEvents.Expanded, this.handleExpanded); | ||
| doc.on(DocumentEvents.Collapsed, this.handleCollapsed); | ||
| } | ||
|
|
||
| /** | ||
| * Unsubscribe from the document events. | ||
| */ | ||
| unsubscribeFromDocumentEvents(doc: Document) { | ||
| doc.on(DocumentEvents.Expanded, this.handleExpanded); | ||
| doc.on(DocumentEvents.Collapsed, this.handleCollapsed); | ||
| } | ||
|
|
||
| handleExpanded = () => { | ||
| this.setState({ expanded: true }); | ||
| }; | ||
|
|
||
| handleCollapsed = () => { | ||
| this.setState({ expanded: false }); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
This is mostly copied from the EditableDocument to react to relevant events on the doc.
kraenhansen
commented
Sep 19, 2024
| static propTypes = { | ||
| copyToClipboard: PropTypes.func, | ||
| doc: PropTypes.object.isRequired, | ||
| expandAll: PropTypes.bool, |
Contributor
Author
There was a problem hiding this comment.
This was extraenuous. Most likely a leftover from some prop that got removed.
kraenhansen
commented
Sep 19, 2024
| value: HadronElementType; | ||
| editable: boolean; | ||
| editingEnabled: boolean; | ||
| extraPaddingLeft?: number; |
Contributor
Author
There was a problem hiding this comment.
The Element in the Document now takes some extraPaddingLeft.
kraenhansen
force-pushed
the
kh/expandable-readonly-document
branch
from
d666bc7 to
51ce1ae
Compare
kraenhansen
force-pushed
the
kh/expandable-readonly-document
branch
from
51ce1ae to
8b9cec2
Compare
Contributor
Author
|
Repurposing the branch and closing this PR in favor of #6447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To follow the design specification outlined in EXPO-2098.
Checklist
ReadonlyDocument(as per design bullet 4).Expand / collapse in the "read only" mode
Screen.Recording.2024-09-19.at.22.54.37.mov
Motivation and Context
Open Questions
Dependents
Types of changes