-
Notifications
You must be signed in to change notification settings - Fork 2k
new[CI]: add linux sanitizer tests #2860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
34d55e6
new[CI]: add linux sanitizer tests
incertum 106b632
fix: correctly add sanitizer compile and link flags also to mlx lib a…
incertum 6a669aa
update: defer enabling TSAN CI checks + ASAN checks w/ GPU backend
incertum 849d0c5
fix rebase gone wrong
incertum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/bin/bash | ||
| set -ex | ||
|
|
||
| export CMAKE_C_COMPILER=/usr/bin/clang | ||
| export CMAKE_CXX_COMPILER=/usr/bin/clang++ | ||
| BASE_CMAKE_ARGS="-DCMAKE_BUILD_TYPE=DEBUG -DCMAKE_COMPILE_WARNING_AS_ERROR=ON" | ||
| if [[ "$(uname -s)" != "Darwin" ]]; then | ||
| BASE_CMAKE_ARGS+=" -DMLX_BUILD_METAL=OFF" | ||
| fi | ||
|
|
||
| run_test() { | ||
| local sanitizer_name=$1 | ||
| local cmake_sanitizer_flag="-DUSE_${sanitizer_name}=ON" | ||
| echo " Running tests with: ${sanitizer_name}" | ||
|
|
||
| case "$sanitizer_name" in | ||
| ASAN) | ||
| export ASAN_OPTIONS="detect_leaks=0" | ||
| ;; | ||
| UBSAN) | ||
| export UBSAN_OPTIONS="halt_on_error=0:print_stacktrace=1" | ||
| ;; | ||
| TSAN) | ||
| export TSAN_OPTIONS="" | ||
| ;; | ||
| esac | ||
|
|
||
| rm -rf build | ||
| mkdir -p build | ||
| pushd build > /dev/null | ||
|
|
||
| cmake .. ${BASE_CMAKE_ARGS} ${cmake_sanitizer_flag} | ||
| make -j $(nproc) | ||
| ./tests/tests | ||
|
|
||
| popd > /dev/null | ||
| unset ${sanitizer_name}_OPTIONS | ||
| } | ||
|
|
||
| sanitizer_arg=$(echo "$1" | tr '[:lower:]' '[:upper:]') | ||
|
|
||
| if [[ "$sanitizer_arg" == "ASAN" || "$sanitizer_arg" == "UBSAN" || "$sanitizer_arg" == "TSAN" ]]; then | ||
| run_test "$sanitizer_arg" | ||
| echo " ${sanitizer_arg} test run completed successfully." | ||
| else | ||
| echo "Error: Invalid sanitizer '$1'. Please use one of: ASAN, UBSAN, TSAN." | ||
| exit 1 | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.