new[CI]: add linux sanitizer tests#2860
Conversation
|
Did this find any bugs? |
Now with the fix on top checkout https://github.com/ml-explore/mlx/actions/runs/19943012002/job/57185456349?pr=2860 ... it seems that we could improve a few things, however note that to be more serious we would need to add fuzzing! Also note that for now I turned of the leak detector etc (see settings). |
|
@awni: @madrob and I chatted and are proposing to defer enabling ASAN and TSAN CI checks until follow up PR(s) where issues will get addressed. What do you think? |
|
Fine with me. Do you plan do to send some of those follow ups? |
Yes I'll try to look into it :) |
Signed-off-by: Melissa Kilby <mkilby@apple.com>
…s PUBLIC Signed-off-by: Melissa Kilby <mkilby@apple.com>
Signed-off-by: Melissa Kilby <mkilby@apple.com>
|
@angeloskath and @awni I have just rebased this PR and the ASAN tests (CPU backend) look good now. The todo comment is also up-to-date plus I created #2915. What would be needed from your perspective to get a v1 of these new checks merged in? |
Signed-off-by: Melissa Kilby <mkilby@apple.com>
Proposed changes
new[CI]: add linux sanitizer tests
CC @madrob
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes