Skip to content

tests(transformers): increase the OLMo models test error passing threshold for BF16 #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

tests(transformers): increase the OLMo models test error passing threshold for BF16 #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/transformers_tests/models/olmo/test_modeling_olmo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
)
from tests.transformers_tests.models.modeling_common import ids_numpy

DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 5e-3}
DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 1e-2}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This DTYPE_AND_THRESHOLDS constant is also defined in tests/transformers_tests/models/olmo2/test_modeling_omo2.py. To improve maintainability and prevent potential inconsistencies, consider moving this constant to a shared module like tests/transformers_tests/models/modeling_common.py and importing it in both test files.

MODES = [0, 1]


Expand Down
2 changes: 1 addition & 1 deletion tests/transformers_tests/models/olmo2/test_modeling_omo2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
)
from tests.transformers_tests.models.modeling_common import ids_numpy

DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 5e-3}
DTYPE_AND_THRESHOLDS = {"fp32": 5e-4, "fp16": 5e-3, "bf16": 1e-2}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This DTYPE_AND_THRESHOLDS constant is also defined in tests/transformers_tests/models/olmo/test_modeling_olmo.py. To improve maintainability and prevent potential inconsistencies, consider moving this constant to a shared module like tests/transformers_tests/models/modeling_common.py and importing it in both test files.

MODES = [0, 1]


Expand Down