Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using predictor as a subselect #297

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Fix using predictor as a subselect #297

merged 5 commits into from
Sep 11, 2023

Conversation

yuhuishi-convect
Copy link
Contributor

@yuhuishi-convect yuhuishi-convect commented Sep 1, 2023 •
edited
Loading

Fix #289

A dep of #287

tmichaeldb
tmichaeldb approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@tmichaeldb tmichaeldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

mindsdb_sql/planner/query_planner.py Outdated Show resolved Hide resolved
tests/test_planner/test_select_from_predictor.py
@@ -360,3 +360,100 @@ def test_select_from_predictor_plan_other_ml(self):
assert plan.steps == expected_plan.steps



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests : )

tests/test_planner/test_select_from_predictor.py Outdated Show resolved Hide resolved
@ea-rus
Copy link
Contributor

ea-rus commented Sep 8, 2023

I've done several updates in PR
@yuhuishi-convect, please take a look

@ea-rus ea-rus mentioned this pull request Sep 8, 2023
Merged
@yuhuishi-convect
Copy link
Contributor Author

I've done several updates in PR @yuhuishi-convect, please take a look

Thanks @ea-rus for making the updates!

@yuhuishi-convect yuhuishi-convect merged commit fb7688f into staging Sep 11, 2023
1 of 7 checks passed
@ea-rus ea-rus mentioned this pull request Sep 21, 2023
Merged
@ea-rus ea-rus deleted the fix/predictor-in-subselect branch October 31, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichaeldb tmichaeldb tmichaeldb approved these changes

@ea-rus ea-rus ea-rus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support of nested select query involving result of ApplyPredictorRow as the RHS of a binary operator
3 participants
@yuhuishi-convect @ea-rus @tmichaeldb