Add sql syntax for knowledge base #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhuishi-convect
force-pushed
the
feature/knowledge-base-sql
branch
from
37ef94c to
a536adf
Compare
tmichaeldb
reviewed
Sep 8, 2023
There was a problem hiding this comment.
Mostly LGTM with a few comments to get more clarification. Would be great if @ea-rus could take a pass at this too :).
ea-rus
reviewed
Sep 8, 2023
8 tasks
yuhuishi-convect
force-pushed
the
feature/knowledge-base-sql
branch
from
e3aab82 to
ce5bd29
Compare
if_not_exists_or_empty if_exists_or_empty
ea-rus
approved these changes
Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #287
Main usage is included in:
mindsdb_sql/tests/test_parser/test_mindsdb/test_knowledgebase.py
Line 21 in bc09c26
Test method