Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [skip e2e] data race in load test #39845

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: [skip e2e] data race in load test #39845

merged 1 commit into from
Feb 18, 2025

Conversation

weiliu1031
Copy link
Contributor

Related to #39701

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/test sig/testing test/integration integration test labels Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 13, 2025
@weiliu1031 weiliu1031 mentioned this pull request Feb 13, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.32%. Comparing base (a4dbbc2) to head (2c2430a).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39845      +/-   ##
==========================================
+ Coverage   79.81%   81.32%   +1.51%     
==========================================
  Files        1496     1191     -305     
  Lines      206990   179646   -27344     
==========================================
- Hits       165210   146101   -19109     
+ Misses      35784    27538    -8246     
- Partials     5996     6007      +11
Components Coverage Δ
Client 79.24% <ø> (ø)
Core ∅ <ø> (∅)
Go 81.43% <ø> (-0.05%) ⬇️

see 355 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031 weiliu1031 changed the title fix: data race in load test fix: [skip e2e] data race in load test Feb 18, 2025
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Feb 18, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 18, 2025
@weiliu1031
fix: [skip e2e] [2.5]data race in load test (#39846)
d92ffb6 
Related to #39701
pr: #39845

Signed-off-by: Wei Liu <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Feb 18, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 946a344 into milvus-io:master Feb 18, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@wayblink wayblink Awaiting requested review from wayblink

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XS Denotes a PR that changes 0-9 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @czs007 @sre-ci-robot @yanliang567