Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [skip e2e] [2.5]data race in load test #39846

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

weiliu1031
Copy link
Contributor

Related to #39701
pr: #39845

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/test sig/testing test/integration integration test labels Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 13, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (52434cc) to head (b241447).
Report is 6 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39846      +/-   ##
==========================================
+ Coverage   81.00%   82.75%   +1.75%     
==========================================
  Files        1421     1118     -303     
  Lines      201313   173151   -28162     
==========================================
- Hits       163065   143292   -19773     
+ Misses      32546    24155    -8391     
- Partials     5702     5704       +2     
Components Coverage Δ
Client 79.28% <ø> (ø)
Core ∅ <ø> (∅)
Go 82.90% <ø> (-0.03%) ⬇️

see 331 files with indirect coverage changes

@weiliu1031 weiliu1031 changed the title fix: [2.5] data race in load test fix: [skip e2e] [2.5]data race in load test Feb 13, 2025
@zhikunyao
Copy link
Collaborator

/run-cpu-e2e

1 similar comment
@zhikunyao
Copy link
Collaborator

/run-cpu-e2e

@mergify mergify bot removed the ci-passed label Feb 14, 2025
@czs007 czs007 requested review from czs007 and removed request for wayblink February 14, 2025 06:12
@mergify mergify bot removed the ci-passed label Feb 14, 2025
@sre-ci-robot sre-ci-robot removed the lgtm label Feb 17, 2025
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Feb 18, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 18, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit d92ffb6 into milvus-io:2.5 Feb 18, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XS Denotes a PR that changes 0-9 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants