Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove load field & schema column size check #39833

Merged

Conversation

congqixia
Copy link
Contributor

Related to #39788

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 13, 2025
Copy link
Contributor

mergify bot commented Feb 13, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 13, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (0988807) to head (ba1f551).
Report is 46 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39833      +/-   ##
==========================================
- Coverage   80.11%   80.10%   -0.01%     
==========================================
  Files        1486     1486              
  Lines      205387   205386       -1     
==========================================
- Hits       164540   164527      -13     
- Misses      34919    34937      +18     
+ Partials     5928     5922       -6     
Components Coverage Δ
Client 79.27% <ø> (ø)
Core 69.39% <ø> (-0.01%) ⬇️
Go 81.83% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 82.27% <ø> (-0.05%) ⬇️

... and 30 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
Cherry-pick from master
pr: #39833
Related to #39788

---------

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
Cherry-pick from master
pr: #39833
Related to #39788

---------

Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label Feb 13, 2025
@sunby
Copy link
Contributor

sunby commented Feb 18, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 59881a7 into milvus-io:master Feb 18, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants