Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Remove load field & schema column size check #39834

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #39833
Related to #39788

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (11ce8ff) to head (0395344).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39834      +/-   ##
==========================================
+ Coverage   72.17%   80.35%   +8.18%     
==========================================
  Files        1081     1081              
  Lines      170426   170425       -1     
==========================================
+ Hits       123004   136946   +13942     
+ Misses      42890    28951   -13939     
+ Partials     4532     4528       -4     
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 70.51% <ø> (+70.51%) ⬆️

... and 238 files with indirect coverage changes

@congqixia congqixia added this to the 2.4.22 milestone Feb 13, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0721afb into milvus-io:2.4 Feb 13, 2025
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
Cherry-pick from master
pr: #39833
Related to #39788

---------

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants