-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: return topks when search in restful v2 #39812
Conversation
@smellthemoon go-sdk check failed, comment |
@smellthemoon E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39812 +/- ##
==========================================
+ Coverage 80.04% 80.06% +0.02%
==========================================
Files 1488 1488
Lines 205913 205913
==========================================
+ Hits 164828 164872 +44
+ Misses 35108 35077 -31
+ Partials 5977 5964 -13
|
20a80f3
to
d7dd0a1
Compare
@smellthemoon go-sdk check failed, comment |
@smellthemoon E2e jenkins job failed, comment |
d7dd0a1
to
de747aa
Compare
@smellthemoon E2e jenkins job failed, comment |
de747aa
to
db53ed8
Compare
@smellthemoon go-sdk check failed, comment |
rerun go-sdk |
@smellthemoon go-sdk check failed, comment |
pr: #39812 2.5: #39839 Signed-off-by: lixinguo <[email protected]> Co-authored-by: lixinguo <[email protected]>
rerun go-sdk |
pr: #39812 Signed-off-by: lixinguo <[email protected]> Co-authored-by: lixinguo <[email protected]>
@smellthemoon go-sdk check failed, comment |
rerun go-sdk |
@smellthemoon go-sdk check failed, comment |
Signed-off-by: lixinguo <[email protected]>
db53ed8
to
82f2b10
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smellthemoon, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if nq>2, restful will flatten all the res. If one nq res has duplicate pks, the length of this slice will be less then topk. This pr
will attach topks in the output.