Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance:[2.4] return topks when search in restful v2 #39858

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

smellthemoon
Copy link
Contributor

pr: #39812
2.5: #39839

@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. labels Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 13, 2025
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.4.22 milestone Feb 13, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.41%. Comparing base (c9c9ef9) to head (daefff0).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39858      +/-   ##
==========================================
- Coverage   80.36%   70.41%   -9.96%     
==========================================
  Files        1081     1081              
  Lines      170442   170448       +6     
==========================================
- Hits       136968   120013   -16955     
- Misses      28949    45916   +16967     
+ Partials     4525     4519       -6     
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.82% <66.66%> (ø)

... and 267 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 13, 2025
@sre-ci-robot sre-ci-robot merged commit f39b45a into milvus-io:2.4 Feb 13, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants