Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: generate guaranteets at delegator if local wal #39799

Merged
merged 2 commits into from
Feb 17, 2025
Merged

enhance: generate guaranteets at delegator if local wal #39799

merged 2 commits into from
Feb 17, 2025

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 11, 2025 •
edited
Loading

issue: #38399, #39892

  • use mvcc timestamp of wal as guaranteets if wal and delegator is located at same node.
  • fix: ignore growing option is lost at hibridsearch

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 11, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 11, 2025
@chyezh chyezh mentioned this pull request Feb 10, 2025
Closed
12 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 11, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 11, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 11, 2025

rerun go-sdk

@chyezh
Copy link
Contributor Author

chyezh commented Feb 11, 2025

/run-cpu-e2e

@chyezh chyezh added this to the 2.6.0 milestone Feb 11, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (61cc223) to head (f967dc0).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...al/streamingnode/server/wal/adaptor/wal_adaptor.go 35.29% 8 Missing and 3 partials ⚠️
...al/interceptors/timetick/timetick_sync_operator.go 50.00% 4 Missing and 1 partial ⚠️
internal/proxy/task_search.go 70.00% 2 Missing and 1 partial ⚠️
...treamingnode/client/handler/handler_client_impl.go 82.35% 2 Missing and 1 partial ⚠️
internal/proxy/task_query.go 50.00% 1 Missing and 1 partial ⚠️
.../wal/interceptors/timetick/timetick_interceptor.go 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39799      +/-   ##
==========================================
- Coverage   79.77%   79.76%   -0.02%     
==========================================
  Files        1494     1495       +1     
  Lines      206729   206878     +149     
==========================================
+ Hits       164914   165006      +92     
- Misses      35818    35859      +41     
- Partials     5997     6013      +16
Components Coverage Δ
Client 79.24% <ø> (ø)
Core 69.50% <ø> (ø)
Go 81.42% <84.61%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/streaming/streaming.go 100.00% <ø> (ø)
internal/distributed/streaming/wal.go 66.94% <100.00%> (+2.08%) ⬆️
internal/proxy/task.go 80.76% <100.00%> (+0.10%) ⬆️
internal/querynodev2/delegator/delegator.go 87.02% <100.00%> (+0.79%) ⬆️
...nal/streamingnode/client/handler/handler_client.go 96.82% <ø> (ø)
...ver/wal/interceptors/timetick/mvcc/mvcc_manager.go 100.00% <100.00%> (ø)
internal/proxy/task_query.go 81.03% <50.00%> (-0.18%) ⬇️
.../wal/interceptors/timetick/timetick_interceptor.go 62.14% <80.00%> (+2.29%) ⬆️
internal/proxy/task_search.go 76.07% <70.00%> (-0.35%) ⬇️
...treamingnode/client/handler/handler_client_impl.go 81.76% <82.35%> (+0.07%) ⬆️
... and 2 more

... and 31 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 11, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 11, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 11, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Feb 11, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 11, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh chyezh force-pushed the enhance_make_delegator_notification branch from 2057c38 to 43df0ca Compare February 12, 2025 12:31
@chyezh chyezh changed the title enhance: active trigger timetick sync when search and query enhance: generate guaranteets at delegator if local wal Feb 12, 2025
@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Feb 12, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 12, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 12, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_make_delegator_notification branch from 43df0ca to 4ba5ca0 Compare February 13, 2025 02:12
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

/run-cpu-e2e

3 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

/run-cpu-e2e

@chyezh chyezh force-pushed the enhance_make_delegator_notification branch from becfa7f to bc0c10e Compare February 13, 2025 10:05
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. dco-passed DCO check passed. and removed dco-passed DCO check passed. needs-dco DCO is missing in this pull request. labels Feb 13, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

rerun go-sdk

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Feb 13, 2025

rerun go-sdk

@chyezh chyezh force-pushed the enhance_make_delegator_notification branch from bc0c10e to c6a3c62 Compare February 13, 2025 13:36
@mergify mergify bot added the ci-passed label Feb 13, 2025
@chyezh chyezh force-pushed the enhance_make_delegator_notification branch from c6a3c62 to 94a08df Compare February 16, 2025 03:21
@chyezh chyezh force-pushed the enhance_make_delegator_notification branch from 94a08df to 7e826db Compare February 16, 2025 03:21
@mergify mergify bot removed the ci-passed label Feb 16, 2025
@chyezh chyezh mentioned this pull request Feb 16, 2025
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 16, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Feb 16, 2025

/run-cpu-e2e

@chyezh chyezh mentioned this pull request Feb 16, 2025
Merged
@mergify mergify bot added the ci-passed label Feb 16, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 21724ab into milvus-io:master Feb 17, 2025
19 of 20 checks passed
@chyezh chyezh deleted the enhance_make_delegator_notification branch February 17, 2025 07:22
sre-ci-robot pushed a commit that referenced this pull request Feb 17, 2025
@chyezh
fix: ignore growing option is lost at hibridsearch (#39900)
56c1a8d 
issue: #39892
pr: #39799

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@jaime0815 jaime0815

Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chyezh @sre-ci-robot @jaime0815