Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore growing option is lost at hibridsearch #39893

Closed

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 14, 2025

issue: #39892

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Feb 14, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 14, 2025
Copy link
Contributor

mergify bot commented Feb 14, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (b9e3ec7) to head (f695b20).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_search.go 66.66% 2 Missing and 1 partial ⚠️
internal/proxy/task_query.go 0.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (76.19%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39893      +/-   ##
==========================================
- Coverage   80.10%   80.04%   -0.06%     
==========================================
  Files        1488     1488              
  Lines      205854   205853       -1     
==========================================
- Hits       164893   164781     -112     
- Misses      35022    35108      +86     
- Partials     5939     5964      +25     
Components Coverage Δ
Client 79.24% <ø> (ø)
Core 69.40% <ø> (ø)
Go 81.76% <76.19%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/task.go 80.76% <100.00%> (+0.10%) ⬆️
internal/querynodev2/delegator/delegator.go 86.22% <100.00%> (ø)
internal/proxy/task_query.go 80.92% <0.00%> (-0.28%) ⬇️
internal/proxy/task_search.go 76.01% <66.66%> (-0.41%) ⬇️

... and 32 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Feb 14, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 14, 2025
@chyezh
Copy link
Contributor Author

chyezh commented Feb 16, 2025

conflict with #39799

@chyezh chyezh closed this Feb 16, 2025
@chyezh chyezh deleted the fix_ignore_growing_hibridsearch branch February 16, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants