Skip to content

fix(openstory): keep centered portal stories stable #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-million merged 1 commit into from
Jul 18, 2026
Merged

fix(openstory): keep centered portal stories stable #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-portals-rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"openstory": patch
---

Keep centered stories stable when components render content through portals.
6 changes: 2 additions & 4 deletions packages/openstory/src/cli/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
DEFAULT_IGNORE_GLOBS,
DEFAULT_STORY_GLOBS,
OPENSTORY_DEFAULT_LAYOUT,
OPENSTORY_IFRAME_STYLES,
OPENSTORY_LAYOUT_CLASSES,
OPENSTORY_ROOT_ELEMENT_ID,
VIRTUAL_STORY_ENTRY_ID,
Expand Down Expand Up @@ -118,10 +119,7 @@ const renderStoryHtmlForBuild = (
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>${escapedStoryId} · ${titleSuffix}</title>
<style>
html, body { margin: 0; padding: 0; min-height: 100%; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif; }
body.openstory-layout-centered { display: grid; place-items: center; min-height: 100vh; padding: 16px; box-sizing: border-box; }
body.openstory-layout-fullscreen #${OPENSTORY_ROOT_ELEMENT_ID} { min-height: 100vh; }
body.openstory-layout-padded #${OPENSTORY_ROOT_ELEMENT_ID} { padding: 16px; }
${OPENSTORY_IFRAME_STYLES}
</style>
${cssLinks}
<script>window.__OPENSTORY_STORY__ = ${initialStoryGlobal};</script>
Expand Down
4 changes: 4 additions & 0 deletions packages/openstory/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export const OPENSTORY_LAYOUT_CLASSES: Record<string, string> = {
padded: "openstory-layout-padded",
};
export const OPENSTORY_DEFAULT_LAYOUT = "padded";
export const OPENSTORY_IFRAME_STYLES = ` html, body { margin: 0; padding: 0; min-height: 100%; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif; }
body.openstory-layout-centered #${OPENSTORY_ROOT_ELEMENT_ID} { display: grid; place-items: center; min-height: 100vh; padding: 16px; box-sizing: border-box; }
body.openstory-layout-fullscreen #${OPENSTORY_ROOT_ELEMENT_ID} { min-height: 100vh; }
body.openstory-layout-padded #${OPENSTORY_ROOT_ELEMENT_ID} { padding: 16px; }`;

export const URL_KV_PAIR_SEPARATOR = ";";
export const URL_KV_KEY_VALUE_SEPARATOR = ":";
Expand Down
6 changes: 2 additions & 4 deletions packages/openstory/src/plugin/virtual-modules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {
OPENSTORY_DEFAULT_LAYOUT,
OPENSTORY_FRAMEWORK_TO_ADAPTER,
OPENSTORY_IFRAME_STYLES,
OPENSTORY_LAYOUT_CLASSES,
OPENSTORY_ROOT_ELEMENT_ID,
VIRTUAL_NULL_PREFIX,
Expand Down Expand Up @@ -94,10 +95,7 @@ export const renderStoryIframeHtml = (options: RenderStoryIframeHtmlOptions): st
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>${escapedStoryId} · ${titleSuffix}</title>
<style>
html, body { margin: 0; padding: 0; min-height: 100%; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif; }
body.openstory-layout-centered { display: grid; place-items: center; min-height: 100vh; padding: 16px; box-sizing: border-box; }
body.openstory-layout-fullscreen #${OPENSTORY_ROOT_ELEMENT_ID} { min-height: 100vh; }
body.openstory-layout-padded #${OPENSTORY_ROOT_ELEMENT_ID} { padding: 16px; }
${OPENSTORY_IFRAME_STYLES}
</style>
<script>window.__OPENSTORY_STORY__ = ${initialStoryGlobal};</script>
</head>
Expand Down
17 changes: 16 additions & 1 deletion packages/openstory/tests/plugin/virtual-modules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, expect, it } from "vitest";
import { synthesizeStoryEntry } from "../../src/plugin/virtual-modules.js";
import { renderStoryIframeHtml, synthesizeStoryEntry } from "../../src/plugin/virtual-modules.js";
import type { Framework, ManifestStory } from "../../src/types.js";

const baseSynthesizedStory: ManifestStory = {
Expand Down Expand Up @@ -38,6 +38,21 @@ const FRAMEWORK_RENDER_EXPECTATIONS: Record<Framework, { importLine: RegExp; ren
},
};

describe("renderStoryIframeHtml", () => {
it("centers the story root without making body portals grid items", () => {
const html = renderStoryIframeHtml({
story: {
...baseSynthesizedStory,
parameters: { layout: "centered" },
},
});

expect(html).toContain('body class="openstory-layout-centered"');
expect(html).toContain("body.openstory-layout-centered #openstory-root { display: grid;");
expect(html).not.toMatch(/body\.openstory-layout-centered\s*\{\s*display:\s*grid/);
});
});

describe("synthesizeStoryEntry - synthesized component stories", () => {
for (const framework of Object.keys(FRAMEWORK_RENDER_EXPECTATIONS) as Framework[]) {
it(`emits a render function for ${framework}`, () => {
Expand Down
Loading