fix(openstory): keep centered portal stories stable - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#openstory-rootinstead of the iframebodyWhy
Base UI and other portal implementations append a wrapper directly to
body. When OpenStory's centered layout madebodya grid container, that wrapper became a second grid item and moved the story root. Hover-triggered portals then moved their own trigger out from under the pointer and immediately closed.Scoping the grid to
#openstory-rootkeeps portaled body children out of the centering layout.Validation
nr buildnr test— 239 passed, 6 skippednr lintnr typechecknr formatnr format:check