Skip to content

fix(openstory): keep centered portal stories stable - #5

Merged
ben-million merged 1 commit into
mainfrom
fix/centered-layout-portals
Jul 18, 2026
Merged

fix(openstory): keep centered portal stories stable#5
ben-million merged 1 commit into
mainfrom
fix/centered-layout-portals

Conversation

@ben-million

Copy link
Copy Markdown
Contributor

Summary

  • center #openstory-root instead of the iframe body
  • keep the dev and static-build iframe styles in one shared constant
  • add a regression test and patch changeset

Why

Base UI and other portal implementations append a wrapper directly to body. When OpenStory's centered layout made body a grid container, that wrapper became a second grid item and moved the story root. Hover-triggered portals then moved their own trigger out from under the pointer and immediately closed.

Scoping the grid to #openstory-root keeps portaled body children out of the centering layout.

Validation

  • nr build
  • nr test — 239 passed, 6 skipped
  • nr lint
  • nr typecheck
  • nr format
  • nr format:check
  • Playwright validation against the million-ui Navigation Menu, Preview Card, and Tooltip stories
  • static OpenStory build validation

@ben-million
ben-million merged commit 8f74312 into main Jul 18, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant