chore: update electron@42.6.0#325428
Draft
deepak1556 wants to merge 6 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Electron runtime to 42.6.0, including its Chromium and Node.js revisions, to enable the Chromium PDF viewer.
Changes:
- Updates Electron, Chromium, Node.js, manifests, checksums, and build configuration.
- Adds npm dependency-script allowlists.
- Refreshes lockfile metadata.
Show a summary per file
| File | Description |
|---|---|
.npmrc |
Targets Electron 42.6.0 and its build. |
.nvmrc |
Updates Node.js to 24.18.0. |
package.json |
Updates Electron and adds script approvals. |
package-lock.json |
Locks Electron 42.6.0. |
cgmanifest.json |
Updates runtime component metadata. |
remote/.npmrc |
Targets Node.js 24.18.0. |
remote/package.json |
Adds remote dependency-script approvals. |
remote/package-lock.json |
Refreshes optional dependency metadata. |
test/automation/package.json |
Approves the fsevents install script. |
extensions/package.json |
Approves extension build scripts. |
extensions/copilot/.nvmrc |
Aligns Copilot with Node.js 24.18.0. |
extensions/copilot/package.json |
Adds Copilot dependency-script approvals. |
extensions/git/package.json |
Approves fs-copyfile installation. |
extensions/mermaid-markdown-features/package.json |
Approves fsevents installation. |
extensions/microsoft-authentication/package.json |
Approves MSAL native scripts. |
build/package.json |
Adds build dependency-script approvals. |
build/vite/package.json |
Approves fsevents installation. |
build/checksums/electron.txt |
Updates Electron artifact checksums. |
build/checksums/nodejs.txt |
Updates Node.js artifact checksums. |
build/linux/dependencies-generator.ts |
References the new Chromium revision. |
build/azure-pipelines/linux/setup-env.sh |
Updates Chromium toolchain sources. |
Review details
Files not reviewed (1)
- remote/package-lock.json: Generated file
- Files reviewed: 19/21 changed files
- Comments generated: 2
- Review effort level: Medium
deepak1556
force-pushed
the
robo/update_electron
branch
from
58cfc3e to
d0bcbff
Compare
Collaborator
Author
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://releases.electronjs.org/release/compare/v42.5.0/v42.6.0
Fixes #323051
Note
npm version bump with this update brings in support for explicit approval of install scripts. The explicitly allowed ones all carry a native module dependency build, with only exception of ssh2 being disallowed as we don't use its native cpu-features. Refs https://github.com/microsoft/vscode/pull/307435/changes (cc @roblourens)