Skip to content

chore: bump electron@42.6.1 (fix Node 24.16-24.17 stream regression)#325329

Closed
asJEI wants to merge 6 commits into
microsoft:mainfrom
asJEI:bump-electron-42.6.1
Closed

chore: bump electron@42.6.1 (fix Node 24.16-24.17 stream regression)#325329
asJEI wants to merge 6 commits into
microsoft:mainfrom
asJEI:bump-electron-42.6.1

Conversation

@asJEI

@asJEI asJEI commented Jul 10, 2026

Copy link
Copy Markdown

Summary

Why

VS Code Electron Node.js Status
1.127.x 42.2.0 24.15.0 OK
1.128.0 42.5.0 24.17.0 Affected
this PR 42.6.1 24.18.0 Fixed upstream

Upstream: nodejs/node#63487 (fixed in Node 24.18.0 via revert).
Electron 42.6.0+ already includes Node 24.18.0.

Regressing VS Code commit (runtime bump): 4b6f5e55bb / #321629

Still needed from maintainers

This draft updates the version pins and Node checksums, but a complete Electron bump also needs:

  1. build/checksums/electron.txt regenerated for 42.6.1
  2. .npmrc ms_build_id for Electron 42.6.1 (currently left as the 42.5.0 id)
  3. cgmanifest.json / package-lock.json refresh
  4. Any other files normally touched by the Electron roller (see chore: bump electron@42.5.0 #321629)

Please help complete those pieces if this direction looks right.

Test plan

@asJEI

asJEI commented Jul 10, 2026 via email

Copy link
Copy Markdown
Author

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps Electron and Node.js to versions containing the upstream stream-regression fix.

Changes:

  • Updates Electron to 42.6.1.
  • Updates Node.js pins and checksums to 24.18.0.
  • Updates Copilot extension development runtime.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.npmrc Pins Electron 42.6.1.
.nvmrc Pins Node.js 24.18.0.
build/checksums/nodejs.txt Adds Node.js 24.18.0 checksums.
extensions/copilot/.nvmrc Updates the Copilot development runtime.
package.json Updates the Electron dependency.
remote/.npmrc Updates the remote Node.js target.

Comment thread .npmrc
@@ -1,5 +1,5 @@
disturl="https://electronjs.org/headers"
target="42.5.0"
target="42.6.1"
Comment thread package.json
"debounce": "^1.0.0",
"deemon": "^1.13.6",
"electron": "42.5.0",
"electron": "42.6.1",
Comment thread .nvmrc
@@ -1 +1 @@
24.17.0
24.18.0
Comment thread remote/.npmrc
@@ -1,5 +1,5 @@
disturl="https://nodejs.org/dist"
target="24.17.0"
target="24.18.0"
asJEI added a commit to asJEI/opensource-mentor that referenced this pull request Jul 11, 2026
- 新增 AI 导师对话页面(替换原成长统计占位项)
- 支持快速提问、消息气泡、打字动画、复制回复等交互
- 仓库切换时弹窗确认是否清空对话
- 代码审查页 Demo 化:仅保留 PR 链接,Diff/文件上传标注未完成
- 预设示例 PR: microsoft/vscode/pull/325329
- Dashboard 新增首次使用引导卡片
- 代码审查空状态新增快捷 Issue 选择
- Roadmap 修复硬编码仓库问题,支持动态切换
@deepak1556

Copy link
Copy Markdown
Collaborator

This will be addressed in #325428

@deepak1556 deepak1556 closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants