Encapsulate qsharp.estimate into Circuit#428
Merged
wavefunction91 merged 9 commits intomainfrom Apr 2, 2026
Merged
Conversation
wavefunction91
requested review from
ConradJohnston,
nabbelbabbel and
sobolevnrm
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Python Circuit API by encapsulating Q# logical resource estimation behind a Circuit.estimate() method, avoiding direct access to internal _qsharp_factory fields (per #427).
Changes:
- Add
Circuit.estimate(params=None)to estimate resources from either Q# factory data or a QASM representation. - Add unit tests covering estimation from Q# factory, from QASM, and the error case when only QIR is available.
- Update the
state_prep_energyexample notebook to useCircuit.estimate()instead of callingqsharp.estimate(...)/qdk.openqasm.estimate(...)directly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/src/qdk_chemistry/data/circuit.py | Introduces Circuit.estimate() and routes estimation through Q# factory data or QASM. |
| python/tests/test_circuit.py | Adds tests validating the new Circuit.estimate() behavior and error handling. |
| examples/state_prep_energy.ipynb | Updates example usage to call Circuit.estimate() for improved UX. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Coverage Summary
Detailed Coverage ReportsC++ Coverage DetailsPython Coverage DetailsPybind11 Coverage Details |
RushiGong
previously approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nabbelbabbel
reviewed
Apr 1, 2026
nabbelbabbel
reviewed
Apr 1, 2026
nabbelbabbel
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427