PR comments

Author: wavefunction91

python/src/qdk_chemistry/data/circuit.py

@@ -19,6 +19,7 @@
 
 import h5py
 import qsharp._native
+import qsharp.estimator
 import qsharp.openqasm
 from qsharp.openqasm import OutputSemantics
 
@@ -192,12 +193,18 @@ def get_qsharp_circuit(self, prune_classical_qubits: bool = False) -> qsharp._na
 
         raise RuntimeError("The quantum circuit is not set in a Q# format.")
 
-    def estimate(self, params=None):
-        """Estimate logical resources for the quantum circuit.
+    def estimate(
+        self,
+        params: dict[str, Any] | list[Any] | qsharp.estimator.EstimatorParams | None = None,
+    ) -> qsharp.estimator.EstimatorResult:
+        """Estimate resources for the quantum circuit.
 
         Args:
-            params: Optional parameters to configure physical estimation. Can be a dictionary,
-                list, or ``qsharp.estimator.EstimatorParams`` instance. Defaults to None.
+            params: Optional parameters to configure resource estimation (for logical and/or
+                physical resources). Can be a dictionary, list, or
+                ``qsharp.estimator.EstimatorParams`` instance. If None, the default estimator
+                settings of the underlying Q# APIs (``qsharp.estimate`` or
+                ``qsharp.openqasm.estimate``) are used.
 
         Returns:
             qsharp.estimator.EstimatorResult: The estimated resources.

python/tests/test_circuit.py

@@ -415,9 +415,15 @@ class TestCircuitEstimate:
 
     def test_estimate_from_factory(self):
         """Test that estimate works with Q# factory data."""
-        state_prep_params = {"rowMap": [1, 0], "stateVector": [0.6, 0.0, 0.0, 0.8], "expansionOps": [], "numQubits": 2}
+        state_prep_params = {
+            "rowMap": [1, 0],
+            "stateVector": [0.6, 0.0, 0.0, 0.8],
+            "expansionOps": [],
+            "numQubits": 2,
+        }
         qsharp_factory = QsharpFactoryData(
-            program=QSHARP_UTILS.StatePreparation.MakeStatePreparationCircuit, parameter=state_prep_params
+            program=QSHARP_UTILS.StatePreparation.MakeStatePreparationCircuit,
+            parameter=state_prep_params,
         )
         circuit = Circuit(qsharp_factory=qsharp_factory)
         result = circuit.estimate()