Skip to content

Fix CapabilityStatement conformance for resources #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-rachitsh wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −0
Open

Fix CapabilityStatement conformance for resources #5617

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22b53d5
Fixes #5394, and megred external PR
v-rachitsh Jun 17, 2026
448d061
fixed the trailing spaces
v-rachitsh Jun 17, 2026
475f56f
added if statement to run only if it's Stu3 version
v-rachitsh Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Microsoft.Health.Fhir.Core/Features/Conformance/CapabilityStatementBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,24 @@ public async Task<ICapabilityStatementBuilder> SyncProfilesAsync(CancellationTok

public ITypedElement Build()
{
// Remove resource entries with no interactions to ensure FHIR conformance.
// In STU3, CapabilityStatement.rest.resource.interaction has min cardinality 1,
// so resources without interactions (e.g. Parameters) must be excluded.

@LTA-Thinking LTA-Thinking Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EXPEkesheth this could technically be called a breaking change. I think it is a correct change, and it should be non-impactful as anything removed in this filter would have no request types. What are your thoughts?

if (_modelInfoProvider.Version == FhirSpecification.Stu3)
{
foreach (var restComponent in _statement.Rest)
{
var emptyResources = restComponent.Resource
.Where(r => r.Interaction == null || r.Interaction.Count == 0)
.ToList();

foreach (var resource in emptyResources)
{
restComponent.Resource.Remove(resource);
}
}
}

// To build a CapabilityStatement we use a custom JsonConverter that serializes
// the ListedCapabilityStatement into a CapabilityStatement poco
var json = JsonConvert.SerializeObject(_statement, new JsonSerializerSettings
Expand Down