Fix CapabilityStatement conformance for resources#5617
Open
v-rachitsh wants to merge 3 commits into
Open
Conversation
v-rachitsh
added
Enhancement-Optimization
v-rachitsh
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5617 +/- ##
==========================================
+ Coverage 76.90% 76.93% +0.02%
==========================================
Files 997 997
Lines 36616 36622 +6
Branches 5529 5533 +4
==========================================
+ Hits 28160 28175 +15
+ Misses 7104 7095 -9
Partials 1352 1352 🚀 New features to boost your workflow:
|
| { | ||
| // Remove resource entries with no interactions to ensure FHIR conformance. | ||
| // In STU3, CapabilityStatement.rest.resource.interaction has min cardinality 1, | ||
| // so resources without interactions (e.g. Parameters) must be excluded. |
Contributor
There was a problem hiding this comment.
@EXPEkesheth this could technically be called a breaking change. I think it is a correct change, and it should be non-impactful as anything removed in this filter would have no request types. What are your thoughts?
| // Remove resource entries with no interactions to ensure FHIR conformance. | ||
| // In STU3, CapabilityStatement.rest.resource.interaction has min cardinality 1, | ||
| // so resources without interactions (e.g. Parameters) must be excluded. | ||
| foreach (var restComponent in _statement.Rest) |
Contributor
There was a problem hiding this comment.
@v-rachitsh I know this is an external PR, but could you add an if statement here so this only runs if the _modelInfoProvider.Version is Stu3? This isn't an issue in other FHIR versions.
Contributor
Author
There was a problem hiding this comment.
@LTA-Thinking Wrapped up in if statement as you have suggested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5394. External PR #5473
In STU3,
CapabilityStatement.rest.resource.interactionhas a minimum cardinality of 1 (spec). Resources likeParametersthat are explicitly excluded from interaction population (line 303-307) were still appearing in the resource list with an empty interaction array, causing FHIR-conformant parsers (e.g., Firely SDK 6.x with strict validation) to reject the CapabilityStatement.Changes
CapabilityStatementBuilder.Build(), added a cleanup step that removes resource entries with no interactions before serializationWhy this approach
Rather than modifying how
Parametersis handled specifically, this cleanup catches any resource that ends up with zero interactions — making it robust against future edge cases. The comment explains the STU3 cardinality requirement for maintainability.Related issues
AB#191808
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)