Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sample scenes #11710

Merged
merged 151 commits into from
Jul 18, 2023
Merged

Conversation

shaynie
Copy link
Collaborator

@shaynie shaynie commented Jul 17, 2023

Overview

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

ThaiHoaVo-work and others added 30 commits May 15, 2023 15:30
Removed scripts from MRTK2 version which are not needed to demonstrate
this functionality.
The previous material would turn black on one side depending what angle
you looked at it from.
Using MRTKLineVisual and BezierDataProvider.
Note that the MRTK2 version of the LineExamples sample scene had more
examples because more data providers were implemented. Additionally, the
MRTKLineVisual ties the lines to an Interactor, unlike the MRTK2
scripts.
Copy link
Member

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I agree with Marlena's comments.

For the samples, it's probably ok to leave some summary blocks out...but add the following to the top and bottom of the sample files if you do:

// Disable "missing XML comment" warning for sample. While nice to have, this documentation is not required for samples. #pragma warning disable CS1591

#pragma warning restore CS1591

This will prevent warnings for missing XML documentation during the build process.

@shaynie shaynie requested a review from AMollis July 18, 2023 18:18
AMollis
AMollis previously approved these changes Jul 18, 2023
Copy link
Member

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sign-off ... assuming @marlenaklein-msft does as well

@shaynie shaynie merged commit d67b126 into microsoft:mrtk3 Jul 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants