-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added interactor list scrolling to MRTK3 (experimental) #11642
Merged
AMollis
merged 39 commits into
microsoft:mrtk3
from
AMollis:user/amollis/mrtk3/list-scrolling-test
Jun 26, 2023
Merged
Added interactor list scrolling to MRTK3 (experimental) #11642
AMollis
merged 39 commits into
microsoft:mrtk3
from
AMollis:user/amollis/mrtk3/list-scrolling-test
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New poke scrolling
AMollis
commented
Jun 22, 2023
UnityProjects/MRTKDevTemplate/Assets/XR/Settings/OpenXR Package Settings.asset
Show resolved
Hide resolved
UnityProjects/MRTKDevTemplate/Assets/Scenes/ScrollingExample.unity
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Interactors/InteractorVisuals/MRTKLineVisual.cs
Show resolved
Hide resolved
com.microsoft.mrtk.core/Experimental/Interactables/InteractableEventRouter.cs
Outdated
Show resolved
Hide resolved
shaynie
previously approved these changes
Jun 26, 2023
com.microsoft.mrtk.core/Experimental/Interactables/InteractableEventRouter.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.core/Experimental/Interactables/InteractableEventRouter.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.core/Experimental/Interactables/InteractableEventRouter.cs
Show resolved
Hide resolved
marlenaklein-msft
previously approved these changes
Jun 26, 2023
shaynie
approved these changes
Jun 26, 2023
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds an experimental method of scrolling through a Unity
ScrollRect
using XRI interactors. The sample scene demonstrates how to scroll through a canvasSrollRect
using both the poke and hand ray interactors.To accomplish this, the new experimental component
InteractableEventRouter
was added. TheInteractableEventRouter
component routes child XRI events to other child and parent game objects that contain theIXRInteractableEventRouteTarget
component.The following image shows a sample usage of this component. In this usage, the
InteractableEventRouter
is configured to bubble up select and hover events from child games objects.Fixes
Known Limitations
The
InteractbleEventRouter
currently can't handleIXRInteractableEventRouteTargets
being dynamically added. So, this may limit some use cases, such as wanting to trickle down events to children added dynamically.Verification