Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnityEngine namespace to avoid collisions #11600

Closed
wants to merge 1 commit into from
Closed

UnityEngine namespace to avoid collisions #11600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions com.microsoft.mrtk.input/Visualizers/HandJointVisualizer/HandJointVisualizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ public class HandJointVisualizer : MonoBehaviour

[SerializeField]
[Tooltip("Joint visualization mesh.")]
private Mesh jointMesh;
private UnityEngine.Mesh jointMesh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this change is needed? I assume you're hitting conflicts with you product namespace, but what I don't understand is why. Unless you're adding a reference to your product assemblies, I don't see how com.microsoft.mrtk.input would pick up your product's namespace.


/// <summary> Joint visualization mesh. </summary>
public Mesh JointMesh { get => jointMesh; set => jointMesh = value; }
public UnityEngine.Mesh JointMesh { get => jointMesh; set => jointMesh = value; }

[SerializeField]
[Tooltip("Joint visualization material.")]
Expand Down