UnityEngine namespace to avoid collisions #11600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-iankudinova
requested review from
marlenaklein-msft,
AMollis and
shaynie
as code owners
AMollis
requested changes
Jun 2, 2023
| @@ -29,10 +29,10 @@ public class HandJointVisualizer : MonoBehaviour | |||
|
|
|||
| [SerializeField] | |||
| [Tooltip("Joint visualization mesh.")] | |||
| private Mesh jointMesh; | |||
| private UnityEngine.Mesh jointMesh; | |||
There was a problem hiding this comment.
I'm curious why this change is needed? I assume you're hitting conflicts with you product namespace, but what I don't understand is why. Unless you're adding a reference to your product assemblies, I don't see how com.microsoft.mrtk.input would pick up your product's namespace.
Cameron-Micka
approved these changes
Jun 2, 2023
|
We found a reason, why collision happened (our artifact was referenced inside mrtk.input). We applied fix on our side, so there is no need fot this change. I will close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixing namespace (UnityEngine.Mesh) clash, when MRTK is used with other packages.
Changes