Skip to content

Add default minimal device config files. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Add default minimal device config files. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1fbe6
toolkit/build/config: Add minimal config files for AE3 and AE7.
iabdalkader Mar 11, 2025
23f0c5a
toolkit/app-gen-toc.py: Use toolkit's config dir by default.
iabdalkader Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion toolkit/app-gen-toc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ def main():
parser.add_argument(
"--config-dir",
type=str,
default="",
default=Path(os.path.dirname(__file__)) / "build/config",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps instead of this, if the config file is not found, search for it in build/config? This way the Makefile could still pass a custom config dir, like the board dir, that contains no files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not have any auto-things, it's too easy for things to go wrong, eg accidentally use the wrong file and you don't realise.

Having a default like you've got it is good.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note though that if you do want to customize a config, you'll have to pass its directory in the Makefile somehow to --config-dir.

help="directory with configuration files",
)
parser.add_argument(
Expand Down
25 changes: 25 additions & 0 deletions toolkit/build/config/app-device-config-ae3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"metadata": {
"device": "AE302F80F55D5AE",
"project": "",
"external_clock_sources": [
{
"id": "OSC_HFXO",
"enabled": true,
"frequency": 38400000
},
{
"id": "OSC_LFXO",
"enabled": true,
"frequency": 32768
}
]
},
"firewall": {
"firewall_components": [],
"region_stitching": false
},
"pinmux": [],
"clocks": {},
"miscellaneous": []
}
25 changes: 25 additions & 0 deletions toolkit/build/config/app-device-config-ae7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"metadata": {
"device": "AE722F80F55D5AS",
"project": "",
"external_clock_sources": [
{
"id": "OSC_HFXO",
"enabled": true,
"frequency": 38400000
},
{
"id": "OSC_LFXO",
"enabled": true,
"frequency": 32768
}
]
},
"firewall": {
"firewall_components": [],
"region_stitching": false
},
"pinmux": [],
"clocks": {},
"miscellaneous": []
}