Add default minimal device config files. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Mar 11, 2025
iabdalkader
force-pushed
the
add_default_cfg_files
branch
from
5ad076d to
51bbb88
Compare
iabdalkader
commented
Mar 11, 2025
| @@ -685,7 +685,7 @@ def main(): | |||
| parser.add_argument( | |||
| "--config-dir", | |||
| type=str, | |||
| default="", | |||
| default=Path(os.path.dirname(__file__)) / "build/config", | |||
There was a problem hiding this comment.
Perhaps instead of this, if the config file is not found, search for it in build/config? This way the Makefile could still pass a custom config dir, like the board dir, that contains no files.
There was a problem hiding this comment.
I'd rather not have any auto-things, it's too easy for things to go wrong, eg accidentally use the wrong file and you don't realise.
Having a default like you've got it is good.
There was a problem hiding this comment.
Note though that if you do want to customize a config, you'll have to pass its directory in the Makefile somehow to --config-dir.
Signed-off-by: iabdalkader <[email protected]>
This change allows AToC config to use a default config file from the toolkit's config dir, if custom one is not required (which is true for most use cases). A custom config file can still be used and customized by boards, by passing a different `--config-dir`. Signed-off-by: iabdalkader <[email protected]>
dpgeorge
force-pushed
the
add_default_cfg_files
branch
from
51bbb88 to
23f0c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.