-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop core-indexing container #314
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f52806f
feat: add env feature for clap
n00m4d 5092470
feat: drop profiling for slot persister
n00m4d 0725a9a
feat: change the way workers take envs
n00m4d 73debce
feat: change env slightly for secondary DB
n00m4d 728af36
feat: drop profiling from docker compose for slot persister
n00m4d ddac9e9
Merge branch 'main' into feat/mtg-924
n00m4d 2d8f4d0
feat: revert changes
n00m4d 5fb21b8
feat: update env.example
n00m4d a96eec8
chore: return back old env example because we have example_new
n00m4d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,40 +41,40 @@ const SLOT_COLLECTION_OFFSET: u64 = 300; | |
)] | ||
struct Args { | ||
/// Path to the target RocksDB instance with slots | ||
#[arg(short, long)] | ||
#[arg(short, long, env)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. specify the Env name here? |
||
target_db_path: PathBuf, | ||
|
||
/// RPC host | ||
#[arg(short, long)] | ||
#[arg(short, long, env)] | ||
rpc_host: String, | ||
|
||
/// Optional starting slot number, this will override the last saved slot in the RocksDB | ||
#[arg(short, long)] | ||
#[arg(short, long, env)] | ||
start_slot: Option<u64>, | ||
|
||
/// Big table credentials file path | ||
#[arg(short, long)] | ||
#[arg(short, long, env)] | ||
big_table_credentials: Option<String>, | ||
|
||
/// Optional big table timeout (default: 1000) | ||
#[arg(short = 'B', long, default_value_t = 1000)] | ||
#[arg(short = 'B', long, env, default_value_t = 1000)] | ||
big_table_timeout: u32, | ||
|
||
/// Metrics port | ||
/// Default: 9090 | ||
#[arg(short, long, default_value = "9090")] | ||
#[arg(short, long, env, default_value = "9090")] | ||
metrics_port: u16, | ||
|
||
/// Number of slots to process in each batch | ||
#[arg(short, long, default_value_t = 200)] | ||
#[arg(short, long, env, default_value_t = 200)] | ||
chunk_size: usize, | ||
|
||
/// Maximum number of concurrent requests | ||
#[arg(short = 'M', long, default_value_t = 20)] | ||
#[arg(short = 'M', long, env, default_value_t = 20)] | ||
max_concurrency: usize, | ||
|
||
/// Optional comma-separated list of slot numbers to check | ||
#[arg(long)] | ||
#[arg(long, env)] | ||
slots: Option<String>, | ||
} | ||
pub struct InMemorySlotsDumper { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value missing from .env.example.
Also some conflicts with the #310 are expected