Drop core-indexing container #314
Conversation
| @@ -41,40 +41,40 @@ const SLOT_COLLECTION_OFFSET: u64 = 300; | |||
| )] | |||
| struct Args { | |||
| /// Path to the target RocksDB instance with slots | |||
| #[arg(short, long)] | |||
| #[arg(short, long, env)] | |||
There was a problem hiding this comment.
specify the Env name here?
.env.example
Outdated
| # Required by Postgre container | ||
| POSTGRE_DB_PATH="postgre/db/path" | ||
| ASSETS_ROCKS_DB_PATH="path/to/assets/db" | ||
| ASSETS_ROCKS_DB_SECONDARY_PATH="path/to/assets_secondary/db" |
There was a problem hiding this comment.
this one will be per service most likely. As it's secondary. Sometimes we could use temp dir for it or if we expect it to grow during the runtime.
.env.example
Outdated
| # Ingester instance config | ||
| INGESTER_LOG_LEVEL=info | ||
| SLOTS_ROCKS_DB_PATH="path/to/slots/db" | ||
| SLOTS_ROCKS_DB_SECONDARY_PATH="path/to/slots_secondary/db" |
docker-compose.yaml
Outdated
| env_file: | ||
| - .env | ||
| network_mode: host | ||
| volumes: | ||
| - ${target_db_path}:${target_db_path}:rw | ||
| - ${INGESTER_PROFILING_FILE_PATH}:${INGESTER_PROFILING_FILE_PATH_CONTAINER}:rw | ||
| - ${TARGET_DB_PATH}:${TARGET_DB_PATH}:rw |
There was a problem hiding this comment.
value missing from .env.example.
Also some conflicts with the #310 are expected
|
UPD: lot of changes were merged already, so previously the goal of this PR was to be able to run slot-persister in Docker container with clap env variables, that changes were merged before this PR. At the moment this PR updates |
|
UPD: now this PR only drops useless core-indexing container from the docker-compose file |
No description provided.