Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation of preventing signing up from anonymous mail domains #125

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

codingmickey
Copy link
Contributor

Notes for Reviewers

Blocking signing up from the following domains:

  • duck.com
  • anodady.me
  • protonmail.com
  • tuta.io

The list can be expanded in the future by just adding more domains in this regex

https://github.com/codingmickey/play/blob/e809dcefef7a10c3d3c7e93f473d78e0be3a310a/site/src/components/SignupForm/index.js#L19

This PR fixes #123

If any changes are required do let me know!

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for meshery-play failed.

Name Link
🔨 Latest commit 93621d8
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/64b5be4d84edcd000896bc96

@leecalcote
Copy link
Member

@codingmickey will you confirm that mutli-word first and last names, whether with whitespace or hyphenations is allowed?

@leecalcote
Copy link
Member

I'm removing other reviewers, who have yet to offer feedback.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingmickey thanks for this. Will you please address the other concern regarding multi-word names?

Will you ensure that the layer5.io forms follow this same approach?

@leecalcote leecalcote merged commit c0b5cae into meshery:master Jul 17, 2023
2 checks passed
@leecalcote
Copy link
Member

@codingmickey Build failure:

5:19:29 PM: src/components/SignupForm/index.js
5:19:29 PM:   Line 50:9:  'errorRole' is assigned a value but never used                                                                                                                                                                                   no-unused-vars
5:19:29 PM:   Line 66:6:  React Hook useEffect has a missing dependency: 'onSubmit'. Either include it or remove the dependency array. If 'onSubmit' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

@codingmickey
Copy link
Contributor Author

@codingmickey thanks for this. Will you please address the other concern regarding multi-word names?

Sure I can work upon that..

Will you ensure that the layer5.io forms follow this same approach?

Aye aye

@codingmickey
Copy link
Contributor Author

@codingmickey Build failure:

5:19:29 PM: src/components/SignupForm/index.js
5:19:29 PM:   Line 50:9:  'errorRole' is assigned a value but never used                                                                                                                                                                                   no-unused-vars
5:19:29 PM:   Line 66:6:  React Hook useEffect has a missing dependency: 'onSubmit'. Either include it or remove the dependency array. If 'onSubmit' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

Oops these didn't occur on my local, sorry about it.. will update and make a new pr

@leecalcote
Copy link
Member

@codingmickey will you consider an update to support this special character issue in the registration forms? - ā

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent signup using anonymous mail domains
2 participants