fix: add modified regex for the firstName and lastName #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartik Jolapara <[email protected]>
❌ Deploy Preview for meshery-play failed.
|
|
Expect a PR regarding the build failure too by today.. |
Avi-88
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Sorry for the delay, this got lost in other notifications. I tested it with a bunch of different names with special characters and also with some multi word names and it handles the spaces correctly so LGTM good work @codingmickey :)
|
Hey @codingmickey |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #125 (review)
Allows
Signed commits