Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md [[Docs] readme: support light and dark mode image versions of Meshery logo] #513

Closed
wants to merge 2 commits into from

Conversation

Rajdeep1311
Copy link

Description

This PR fixes #511

Notes for Reviewers
Thanks, Please review my PR and suggest if any changes needed

Signed commits

  • [ x ] Yes, I signed my commits.

Signed-off-by: Rajdeep Pal <[email protected]>
@welcome
Copy link

welcome bot commented Aug 30, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes needed:

  1. don't reference your own repo
  2. use the raw.githubusercontent.com references
  3. use image references that are of this repo (images must be in this repo).

@Rajdeep1311
Copy link
Author

Thanks. Changes needed:

  1. don't reference your own repo
  2. use the raw.githubusercontent.com references
  3. use image references that are of this repo (images must be in this repo).

Okay sir... On it

@Rajdeep1311
Copy link
Author

@leecalcote sir can you tell me how to use or learn more about raw.githubusercontent.com

@Ghat0tkach
Copy link
Member

@Rajdeep1311 , this isnt a valid issue . You may close this PR

@Ghat0tkach
Copy link
Member

closing this as it isnt a valid issue , Thanks for you contribution @Rajdeep1311 . There are plenty of other issues , you may contribute there as well🙌

@Ghat0tkach Ghat0tkach closed this Sep 10, 2023
@Rajdeep1311
Copy link
Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] readme: support light and dark mode image versions of Meshery logo
3 participants