Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] readme: support light and dark mode image versions of Meshery logo #511

Closed
leecalcote opened this issue Aug 29, 2023 · 12 comments · Fixed by Rajdeep1311/meshery-operator#1
Labels
area/docs Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed language/markdown Issues or pull requests that use Markdown

Comments

@leecalcote
Copy link
Member

Current State

Desired State

See the other repositories for an example.


Contributor Guides and Resources

@leecalcote leecalcote added good first issue Good for newcomers help wanted Extra attention is needed area/docs Improvements or additions to documentation language/markdown Issues or pull requests that use Markdown labels Aug 29, 2023
@Rajdeep1311
Copy link

Can you please tell me details of what is to be done, sir?

@Ghat0tkach
Copy link
Member

hey @Rajdeep1311 ,
The current meshery logo stays same in both light mode and dark mode , However it should be mode-specific
For example , please refer to https://github.com/meshery/meshery readme and notice the logo behavior in both light and dark mode

@Rajdeep1311
Copy link

hey @Rajdeep1311 ,
The current meshery logo stays same in both light mode and dark mode , However it should be mode-specific
For example , please refer to https://github.com/meshery/meshery readme and notice the logo behavior in both light and dark mode

Okay sir... I will check and try to help you out

@Rajdeep1311
Copy link

Sir, the readme shows no Meshery logo but the CNCF logo does not load in dark mode

@Rajdeep1311
Copy link

image

Should I change this?

@Ghat0tkach
Copy link
Member

image

Should I change this?

Meshery logo is top of readme

@Rajdeep1311
Copy link

image

Sir the logo isn't loading, it is not because of the internet speed.
But I have changed it on my local for both the mode

image

image

@Rajdeep1311
Copy link

image

This repo also has the same problem

@Rajdeep1311
Copy link

Sir I have raised a PR #513

@Rajdeep1311
Copy link

@Ghat0tkach Sir I need some help. Where to connect?

@Ghat0tkach
Copy link
Member

@leecalcote , Apologies I didn't recheck the issue , however it seems like readme logo is already compatible for both themes
image

image

@OmAximani0
Copy link

@leecalcote , Apologies I didn't recheck the issue , however it seems like readme logo is already compatible for both themes

Yes I have seen this happening sometimes if there is a network issue the logo and media doesn't loads properly you just have to refresh the page or check the network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed language/markdown Issues or pull requests that use Markdown
Projects
None yet
4 participants