Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMI protobuf Update #33

Merged
merged 5 commits into from
Jan 27, 2021
Merged

SMI protobuf Update #33

merged 5 commits into from
Jan 27, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented Jan 26, 2021

Signed-off-by: dhruv0000 [email protected]

Description

  • Now requires adaptors to
    • have a type: [ServiceMesh_Type].Enum.String() from SMP repo to identify mesh instead of a string to use smi-client
    • Use RunSMITest instead of ValidateSMIConformance to run a test.
  • In smi.go:
    • Changed adaptorVersion to meshVersion
    • Changed adaptorName to meshType
    • The GRPC client request and response changed to updated proto in #70
    • Added event stream to store the data locally.
  • Removed validate.go, since it was having the same functionality of smi.go but was dependent on meshkit/smi package
    This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: dhruv0000 <[email protected]>
@welcome
Copy link

welcome bot commented Jan 26, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Signed-off-by: dhruv0000 <[email protected]>
Signed-off-by: dhruv0000 <[email protected]>
Signed-off-by: dhruv0000 <[email protected]>
Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 marked this pull request as ready for review January 27, 2021 21:37
@leecalcote leecalcote merged commit 50f4c3b into meshery:master Jan 27, 2021
@welcome
Copy link

welcome bot commented Jan 27, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@leecalcote leecalcote self-requested a review January 27, 2021 21:40
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants