Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Updated params to include Mesh Type #71

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Updated params to include Mesh Type #71

merged 3 commits into from
Jan 27, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented Jan 27, 2021 •
edited
Loading

Signed-off-by: dhruv0000 [email protected]

Description

This PR fixes of changes in #31 and #33

Notes for Reviewers

  • Added "type" in MeshSpecDefaults
  • Removed redundant SMI Test successful Event notification.
  • Updated go.mod to point to master branch

Signed commits

  • Yes, I signed my commits.

@dhruv0000
Added mesh Type
2220df9 
Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 mentioned this pull request Jan 27, 2021
Merged
1 task
@dhruv0000
Minor Update
40147bf 
Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000
Updated go.mod
50719d5 
Signed-off-by: dhruv0000 <[email protected]>
@dhruv0000 dhruv0000 marked this pull request as ready for review January 27, 2021 21:57
@dhruv0000 dhruv0000 self-assigned this Jan 27, 2021
leecalcote
leecalcote approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@leecalcote leecalcote merged commit 9f33487 into meshery:master Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees

@dhruv0000 dhruv0000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruv0000 @leecalcote