Add message endpoint #115
Open
Add message endpoint #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
message-endpoint
branch
from
c162968 to
96e7b8a
Compare
mat-hek
reviewed
Nov 17, 2025
examples.livemd
Outdated
| :websockex, | ||
| :membrane_simple_rtsp_server | ||
| :membrane_simple_rtsp_server, | ||
| {:coerce, github: "ypconstante/elixir-coerce", override: true} |
Member
There was a problem hiding this comment.
the coerce fix is finally released, so this shouldn't be needed
examples.livemd
Outdated
Comment on lines
64
to
67
| unless File.exists?("#{input_dir}/test-audio.aac") do | ||
| %{status: 200, body: testsrc_mp4} = Req.get!("#{samples_url}/ffmpeg-testsrc-480x270.mp4") | ||
| File.write!("#{input_dir}/ffmpeg-testsrc.mp4", testsrc_mp4) | ||
| end |
Member
There was a problem hiding this comment.
Suggested change
| unless File.exists?("#{input_dir}/test-audio.aac") do | |
| %{status: 200, body: testsrc_mp4} = Req.get!("#{samples_url}/ffmpeg-testsrc-480x270.mp4") | |
| File.write!("#{input_dir}/ffmpeg-testsrc.mp4", testsrc_mp4) | |
| end | |
| unless File.exists?("#{input_dir}/ffmpeg-testsrc.mp4") do | |
| %{status: 200, body: testsrc_mp4} = Req.get!("#{samples_url}/ffmpeg-testsrc-480x270.mp4") | |
| File.write!("#{input_dir}/ffmpeg-testsrc.mp4", testsrc_mp4) | |
| end |
examples.livemd
Outdated
Comment on lines
594
to
595
| Boombox.close(writer1) | ||
| if result2 == :ok, do: | ||
| Boombox.close(writer2) |
Member
There was a problem hiding this comment.
shouldn't it be
Suggested change
| Boombox.close(writer1) | |
| if result2 == :ok, do: | |
| Boombox.close(writer2) | |
| Boombox.close(reader1) | |
| if result2 == :ok, do: | |
| Boombox.close(reader2) |
?
Contributor
Author
There was a problem hiding this comment.
whoops i thought when i gave a thumbs up i already handled it
Noarkhh
force-pushed
the
message-endpoint
branch
2 times, most recently
from
31ca721 to
88a148a
Compare
Noarkhh
force-pushed
the
message-endpoint
branch
from
88a148a to
e44efe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.