Skip to content

Commit 88a148a

Browse files
committed
Remove opaque types to satisfy dialyzer
1 parent f656615 commit 88a148a

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

examples.livemd

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ Mix.install([
2424
:exla,
2525
:bumblebee,
2626
:websockex,
27-
:membrane_simple_rtsp_server,
28-
{:coerce, github: "ypconstante/elixir-coerce", override: true}
27+
:membrane_simple_rtsp_server
2928
])
3029

3130
Nx.global_default_backend(EXLA.Backend)
@@ -61,7 +60,7 @@ unless File.exists?("#{input_dir}/ffmpeg-testsrc.h264") do
6160
File.write!("#{input_dir}/ffmpeg-testsrc.h264", testsrc_h264)
6261
end
6362

64-
unless File.exists?("#{input_dir}/test-audio.aac") do
63+
unless File.exists?("#{input_dir}/ffmpeg-testsrc.mp4") do
6564
%{status: 200, body: testsrc_mp4} = Req.get!("#{samples_url}/ffmpeg-testsrc-480x270.mp4")
6665
File.write!("#{input_dir}/ffmpeg-testsrc.mp4", testsrc_mp4)
6766
end
@@ -591,9 +590,9 @@ Stream.unfold(%{}, fn _state ->
591590

592591
if :finished in [result1, result2] do
593592
if result1 == :ok, do:
594-
Boombox.close(writer1)
593+
Boombox.close(reader1)
595594
if result2 == :ok, do:
596-
Boombox.close(writer2)
595+
Boombox.close(reader2)
597596
nil
598597
else
599598
{nil, %{}}

lib/boombox.ex

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ defmodule Boombox do
1616
@moduledoc """
1717
Defines a struct to be used when interacting with boombox when using `:writer` endpoint.
1818
"""
19-
@opaque t :: %__MODULE__{
20-
server_reference: GenServer.server()
21-
}
19+
@type t :: %__MODULE__{
20+
server_reference: GenServer.server()
21+
}
2222

2323
@enforce_keys [:server_reference]
2424
defstruct @enforce_keys
@@ -28,9 +28,9 @@ defmodule Boombox do
2828
@moduledoc """
2929
Defines a struct to be used when interacting with boombox when using `:reader` endpoint.
3030
"""
31-
@opaque t :: %__MODULE__{
32-
server_reference: GenServer.server()
33-
}
31+
@type t :: %__MODULE__{
32+
server_reference: GenServer.server()
33+
}
3434

3535
@enforce_keys [:server_reference]
3636
defstruct @enforce_keys

lib/boombox/server.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ defmodule Boombox.Server do
2323

2424
alias Boombox.Packet
2525

26-
@type t :: pid()
26+
@type t :: GenServer.server()
2727

2828
@type communication_medium :: :calls | :messages
2929

0 commit comments

Comments
 (0)