Skip to content

fix(ci): desktop artifact builds no longer fail on a placeholder allowBuilds entry #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmclaren7 merged 2 commits into from
Sep 22, 2026
+9 −3
Merged

fix(ci): desktop artifact builds no longer fail on a placeholder allowBuilds entry #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d44d90d
fix(ci): desktop artifact builds no longer fail on a placeholder allo…
jmclaren7 Sep 22, 2026
f108e5b
fix(ci): reflow the FORK.md note so the formatter check passes
jmclaren7 Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions FORK.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ support (15, 19), a configurable worktree branch prefix (17), upstream's provide
limits surfaced in the model picker and context bubble (22, web-only), and three web UX changes
(5, 6, 18). Everything else is byte-identical to upstream — `native/`, `scripts/` (one
orphaned release script deleted aside, entry 14), `apps/desktop/`, `packages/client-runtime/`
(one test fixture aside), `apps/server/src/persistence/`, `pnpm-lock.yaml` and
`pnpm-workspace.yaml` are untouched, and the only edits under `infra/` and `packaging/` are the
(one test fixture aside), `apps/server/src/persistence/` and `pnpm-lock.yaml` are untouched,
`pnpm-workspace.yaml` differs by one deleted placeholder line (entry 14), and the only edits under `infra/` and `packaging/` are the
entry 14 notes explaining which workflow no longer runs them. Mobile carries
entry 19's usage screens and nothing else.

Expand Down Expand Up @@ -247,6 +247,13 @@ intent against current upstream code, taking upstream's version of anything that
#12417) — no flag, env or job-shape change, so `desktop-artifacts.yml` needed nothing. No
new upstream workflow this range. `grep -rn blacksmith .github/workflows/` still matches only
the explanatory comment in `desktop-artifacts.yml`.
- **Repaired in place at `7a32d882`.** `d547e3b1` (#12326) landed `pnpm-workspace.yaml` with
`msgpackr-extract: set this to true or false` under `allowBuilds`, an unfilled placeholder:
pnpm tolerates it and `ci.yml` stayed green, but `build-desktop-artifact.ts` decodes
`allowBuilds` as a boolean record, so every Desktop Artifacts leg failed on
`SchemaError: Expected boolean`. Nothing in `pnpm-lock.yaml` references that package, and
upstream's current `main` no longer carries the line, so the fork deletes it. Take upstream's
file on the next sync; this is not a fork change to keep.

### 15. A logged-out Claude instance reports as unauthenticated, and shows the directory it resolved

Expand Down
1 change: 0 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ allowBuilds:
electron: true
electron-winstaller: false
esbuild: true
msgpackr-extract: set this to true or false
msw: false
node-pty: true
sharp: true
Expand Down