fix(ci): desktop artifact builds no longer fail on a placeholder allowBuilds entry - #21
Conversation
…wBuilds entry Every Desktop Artifacts leg died in readWorkspaceConfig with "SchemaError: Expected boolean at allowBuilds.msgpackr-extract": pnpm-workspace.yaml carried `msgpackr-extract: set this to true or false`, an unfilled placeholder from the upstream Effect rc.115 dependency bump. pnpm tolerates the string, so CI stayed green, but build-desktop-artifact.ts decodes allowBuilds as a boolean record. Nothing in the lockfile references msgpackr-extract and upstream main has since dropped the line, so delete it and record the repair in FORK.md entry 14. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J6iMDRM6VXUTNdZxk9aJDt
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J6iMDRM6VXUTNdZxk9aJDt
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change matches the workspace schema, observed CI failure, lockfile state, and current upstream configuration.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes desktop artifact builds by removing an invalid allowBuilds placeholder and documenting the fork-specific repair.
Changes:
- Removes the non-boolean
msgpackr-extractentry. - Records the repair and future upstream-sync handling.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Removes the invalid build-policy entry. |
FORK.md |
Documents the repair and sync guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
What Changed
msgpackr-extract: set this to true or falseline underallowBuildsinpnpm-workspace.yaml.FORK.mdentry 14 so the next upstream sync takes upstream's file rather than keeping a fork edit.Why
The Desktop Artifacts workflow on
main(run 33) failed on all four platform legs within seconds of starting the build step, and the publish job then failed because no artifacts existed. Every leg died with:That line is an unfilled placeholder that arrived with the upstream Effect rc.115 dependency bump. pnpm tolerates the string, which is why the CI workflow stayed green, but
build-desktop-artifact.tsdecodesallowBuildsas a record of booleans and refuses it. Nothing inpnpm-lock.yamlreferencesmsgpackr-extract, and upstream's currentmainno longer carries the line, so removing it is the whole fix.Verified locally by running the build script's exact
WorkspaceConfigschema and YAML decoder against both files: the previouspnpm-workspace.yamlreproduces the CI error, the fixed one decodes cleanly.pnpm install --frozen-lockfilestill reports the lockfile as up to date.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01J6iMDRM6VXUTNdZxk9aJDt
Generated by Claude Code