Add SelectByName parameter #148
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| name: 1.14$(Rev:.r) | ||
|
|
||
| trigger: | ||
| - master | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,12 +11,22 @@ export interface IRunTestsOptions { | |
| CoberturaModelCoverage?: string; | ||
| SelectByTag?: string; | ||
| SelectByFolder?: string; | ||
| SelectByName?: string; | ||
| Strict?: boolean; | ||
| UseParallel?: boolean; | ||
| OutputDetail?: string; | ||
| LoggingLevel?: string; | ||
| } | ||
|
|
||
| // Function to convert space separated names to cell array of character vectors | ||
| export function getSelectByNameAsCellArray(input?: string): string { | ||
|
There was a problem hiding this comment. Hopefully this is just temporary until scriptgen gets updated to properly accept SelectByName as a space separated string? While unlikely, single-quotes in the strings need to be escaped or it may result in a malformed cell array. There was a problem hiding this comment. Yes, I created an issue in scritgen repo and added a note to update this once that issue is resolved. |
||
| if (!input || !input.trim()) { | ||
| return "{}"; | ||
| } | ||
| const items = input.split(/\s+/).filter(Boolean).map((s) => `'${s}'`); | ||
Vahila marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
davidbuzinski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return `{${items.join(", ")}}`; | ||
| } | ||
|
|
||
| export function generateCommand(options: IRunTestsOptions): string { | ||
| return `addpath('${path.join(__dirname, "scriptgen")}');` + | ||
| `testScript = genscript('Test',` + | ||
|
|
@@ -28,6 +38,7 @@ export function generateCommand(options: IRunTestsOptions): string { | |
| `'CoberturaModelCoverage','${options.CoberturaModelCoverage || ""}',` + | ||
| `'SelectByTag','${options.SelectByTag || ""}',` + | ||
| `'SelectByFolder','${options.SelectByFolder || ""}',` + | ||
| `'SelectByName',${getSelectByNameAsCellArray(options.SelectByName)},` + | ||
|
There was a problem hiding this comment. Is there a plan to go back and fix scriptgen so this can be:
There was a problem hiding this comment. Yes, created an issue under scriptgen repo. |
||
| `'Strict',${options.Strict || false},` + | ||
| `'UseParallel',${options.UseParallel || false},` + | ||
| `'OutputDetail','${options.OutputDetail || ""}',` + | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,15 @@ | |
| "required": false, | ||
| "helpMarkDown": "Test tag used to select test suite elements. To create a test suite, the task uses only the test elements with the specified tag." | ||
| }, | ||
| { | ||
| "name": "selectByName", | ||
| "type": "string", | ||
| "label": "By name", | ||
| "defaultValue": "", | ||
| "groupName": "filterTests", | ||
| "required": false, | ||
| "helpMarkDown": "Test name used to select test suite elements. To create a test suite, the task uses only the test elements with the specified name." | ||
|
||
| }, | ||
| { | ||
| "name": "strict", | ||
| "type": "boolean", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
! grep -q FirstTest test-results/matlab/selectbytag.xml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove the
!?This is to verify that the 'FirstTest' test is not run so used a
!before thegrepcommand.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget what I meant, but I think I meant to type
selectbyname.xml. Should they all be checking in one .xml for the select by name run?