Add SelectByName parameter #148
Conversation
Vahila
requested review from
davidbuzinski,
mcafaro and
sameagen-MW
and removed request for
davidbuzinski,
mcafaro and
sameagen-MW
tasks/run-matlab-tests/v1/task.json
Outdated
| "defaultValue": "", | ||
| "groupName": "filterTests", | ||
| "required": false, | ||
| "helpMarkDown": "Test name used to select test suite elements. To create a test suite, the task uses only the test elements with the specified name." |
There was a problem hiding this comment.
Thanks for adding this text, Vahila.
@davidbuzinski: Where would such text show up? In the UI?
There was a problem hiding this comment.
It shows up if you try to edit the yaml in the pipeline editor at dev.azure.com. There is a list of all the input fields, and each field has a info icon that you can hover over to see this help text.
integ-test-promote-template.yml
Outdated
| set -e | ||
| grep -q StartupTest test-results/matlab/selectbyname.xml | ||
| grep -q simpleTest test-results/matlab/selectbyname.xml | ||
| ! grep -q FirstTest test-results/matlab/selectbytag.xml |
There was a problem hiding this comment.
Should this be ! grep -q FirstTest test-results/matlab/selectbytag.xml?
There was a problem hiding this comment.
Did you mean to remove the !?
This is to verify that the 'FirstTest' test is not run so used a ! before the grep command.
There was a problem hiding this comment.
I forget what I meant, but I think I meant to type selectbyname.xml. Should they all be checking in one .xml for the select by name run?
tasks/run-matlab-tests/v1/task.json
Outdated
| "defaultValue": "", | ||
| "groupName": "filterTests", | ||
| "required": false, | ||
| "helpMarkDown": "Test name used to select test suite elements. To create a test suite, the task uses only the test elements with the specified name." |
There was a problem hiding this comment.
It shows up if you try to edit the yaml in the pipeline editor at dev.azure.com. There is a list of all the input fields, and each field has a info icon that you can hover over to see this help text.
| } | ||
|
|
||
| // Function to convert space separated names to cell array of character vectors | ||
| export function getSelectByNameAsCellArray(input?: string): string { |
There was a problem hiding this comment.
Hopefully this is just temporary until scriptgen gets updated to properly accept SelectByName as a space separated string?
While unlikely, single-quotes in the strings need to be escaped or it may result in a malformed cell array.
There was a problem hiding this comment.
Yes, I created an issue in scritgen repo and added a note to update this once that issue is resolved.
| `'CoberturaModelCoverage','${options.CoberturaModelCoverage || ""}',` + | ||
| `'SelectByTag','${options.SelectByTag || ""}',` + | ||
| `'SelectByFolder','${options.SelectByFolder || ""}',` + | ||
| `'SelectByName',${getSelectByNameAsCellArray(options.SelectByName)},` + |
There was a problem hiding this comment.
Is there a plan to go back and fix scriptgen so this can be:
'SelectByName','${options.SelectByName || ""}', ?
There was a problem hiding this comment.
Yes, created an issue under scriptgen repo.
tasks/run-matlab-tests/v1/task.json
Outdated
| "defaultValue": "", | ||
| "groupName": "filterTests", | ||
| "required": false, | ||
| "helpMarkDown": "Test name used to select test suite elements. To create a test suite, the task uses only the test elements with the specified name." |
There was a problem hiding this comment.
@Vahila : Would you like to replaced "with the specified name" with "that match the specified name"?
Added new 'SelectByName' parameter. This would help in supporting Parallel Strategy in Azure.
Note: Genscript changes to support SelectByName needs to be available before these can be merged.