Skip to content

fix(Carousel) Fix onCycleTo not being called when slide changed #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2-dev
Choose a base branch
from
Open

fix(Carousel) Fix onCycleTo not being called when slide changed #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/carousel/carousel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,9 @@ export class Carousel extends Component<CarouselOptions> {
this.el.classList.remove('scrolling');
}, this.options.duration);

// Save last center before updating the center for onCycleTo callback
const lastCenter = this.center;

// Start actual scroll
this.offset = typeof x === 'number' ? x : this.offset;
this.center = Math.floor((this.offset + this.dim / 2) / this.dim);
Expand All @@ -496,7 +499,6 @@ export class Carousel extends Component<CarouselOptions> {
zTranslation: number,
tweenedOpacity: number,
centerTweenedOpacity: number;
const lastCenter = this.center;
const numVisibleOffset = 1 / this.options.numVisible;

// delta = this.offset - this.center * this.dim;
Expand Down