Skip to content

Conversation

Jerit3787
Copy link
Member

@Jerit3787 Jerit3787 commented Sep 2, 2025

Proposed changes

fixes #639
This should fix onCycleTo function not being called due to lastCenter != this.center being always false. This pull request moves the position of lastCenter variable to be updated before the this.center was updated.

Screenshots (if appropriate) or codepen:

Previous behavior: CodePen

Intended behavior: Preview / Code

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant